[RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER"

Linus Walleij linus.walleij at linaro.org
Tue Nov 17 06:03:56 PST 2015

On Mon, Nov 16, 2015 at 4:40 AM, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> 2015-11-05 22:40 GMT+09:00 Linus Walleij <linus.walleij at linaro.org>:
>> On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada
>> <yamada.masahiro at socionext.com> wrote:
>>> The dependency "depends on RESET_CONTROLLER" is already met.
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>> NACK, this pin controller needs that as dependency, I don't worry
>> that it's overspecified.
>> They both do this:
>> #include <linux/reset.h>
>> And the object should specify its dependencies, not rely on them
>> being implicitly available.
>> The dep is there for human readers too, not just machines. And to
>> them, this is helpful information.
> How strict we should follow this rule?
> Many drivers depend on OF, but do they all have "depends on OF"?

I think they should, and if they are in my subsystems I consider
it a bug if they don't have this dependency. Also it is a very common
reason why test compiles fail.

Linus Walleij

More information about the linux-arm-kernel mailing list