[PATCH 1/4] watchdog: meson: Enable meson SoC specific data
linux at roeck-us.net
Fri Nov 6 16:02:43 PST 2015
On 11/06/2015 02:47 PM, Carlo Caione wrote:
> On Fri, Nov 6, 2015 at 11:15 PM, Guenter Roeck <linux at roeck-us.net> wrote:
[ ... ]
>>> static int meson_restart_handle(struct notifier_block *this, unsigned long mode,
>>> void *cmd)
>>> - u32 tc_reboot = MESON_WDT_DC_RESET | MESON_WDT_TC_EN;
>>> + u32 tc_reboot = MESON_WDT_DC_RESET;
>>> struct meson_wdt_dev *meson_wdt = container_of(this,
>>> struct meson_wdt_dev,
>>> + tc_reboot |= BIT(meson_wdt->data->shift_enable);
>> I am quite sure that this results in a checkpatch warning.
>> Did you run your patch through checkpatch ?
> Yeah, no error/warnings on that line.
There should be a warning since there is no empty line after the declarations.
Maybe checkpatch doesn't catch it because of the continuation line above.
Still, the extra line would be appreciated.
More information about the linux-arm-kernel