[PATCH v8 2/2] arm-soc: Add support for arm-based tango4 platforms

[Måns Rullgård]

Marc Gonzalez <marc_gonzalez at sigmadesigns.com> writes:

> On 02/11/2015 17:22, Måns Rullgård wrote:
>
>> Unless I'm missing something, you should enable the SCU before starting
>> secondary CPUs.  It's also a good idea to structure the code with
>> separate prepare and boot functions even if all the current chips are
>> only dual-core.
>
> About the SCU: I will check with the firmware author.
> About prepare: this is the firmware's responsibility.
> (Not all chips are dual-core, the 8756 is single-core.)

Then the DT should say so.

Rule 0: never trust the firmware.

>> What about other registers?  Does the firmware support setting the
>> prefetch control register?
>
> Yes, after masking out some bits.

Then you should provide the kernel with a means of doing that.  Is the
SMC ID from OMAP4 correct?

-- 
Måns Rullgård
mans at mansr.com