[PATCHv2 3/3] ARM: exynos_defconfig: Enable LEDs for odroidxu3.

Krzysztof Kozlowski k.kozlowski at samsung.com
Tue May 12 21:13:01 PDT 2015


On 13.05.2015 12:52, Anand Moon wrote:
> Enable CONFIG_LEDS_GPIO, CONFIG_LEDS_TRIGGERS, CONFIG_LEDS_TRIGGER_HEARTBEAT.

1. Remove the trailing stop (dot) from commit title.
2. Please go back to default length of wrapping commit messages. This
one exceeds it. Default is 75 characters so git log or git show output
would fit in 80 characters terminal.
3. It would be nice to see here WHY you are enabling these configs (what
is the benefit). One sentence would be enough.

With these changes you can add my tag:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list