[PATCH v5 3/3] ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.

Tejun Heo tj at kernel.org
Sun May 10 08:54:54 PDT 2015


Hello,

On Wed, May 06, 2015 at 12:51:12AM +0530, Suman Tripathi wrote:
> +	switch (version) {
> +	case XGENE_AHCI_V1:
> +		hpriv->flags = AHCI_HFLAG_NO_NCQ;
> +		/*
> +		 * Override the callbacks for storm ERRATA
> +		 */
> +		xgene_ahci_ops.qc_issue = xgene_ahci_qc_issue;
> +		xgene_ahci_ops.softreset = xgene_ahci_softreset;
> +		xgene_ahci_ops.pmp_softreset = xgene_ahci_pmp_softreset;

Let's please create separate ops structs for v1 and v2.

Thanks.

-- 
tejun



More information about the linux-arm-kernel mailing list