[PATCH] ARM: dts: cubox-i: add support for Broadcom Wifi/Bluetooth devices

Fabio Estevam festevam at gmail.com
Wed May 6 10:16:08 PDT 2015


On Wed, May 6, 2015 at 12:54 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:

> You should also mention that it's a bodge because you're permanently
> enabling the regulators rather than controlling them from the mmc-pwrseq
> stuff.
>
> I would like to see a proper implementation rather than a bodge -
> especially one which permanently enables the oscillator regulator,
> thus having the oscillator output trying to drive a device which is
> powered down, which will forward-bias the ESD diodes... which is not
> a particularly nice thing to do.
>
> So really that's a NAK on this.  Please do the job properly.

Good point. I have prepared a v2 with the proper bindings now.

Regards,

Fabio Estevam



More information about the linux-arm-kernel mailing list