[PATCH 2/2] ARM: dts: imx25-karo-tx25: Fix pincontrol definition

[Markus Pargmann]

Hi,

On Tue, Mar 24, 2015 at 08:50:46PM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> [Cc += Lothar Waßmann]
> 
> On Tue, Mar 24, 2015 at 03:09:07PM +0100, Markus Pargmann wrote:
> > The iomux group nodes have to be in a pinmux category as described in
> > the devicetree binding documentation example. The current definitions
> > are not parsed by imx25-pinctrl.
> I remember having noticed that problem, too, some time ago, but forgot
> to fix/report it.
> 
> > Signed-off-by: Markus Pargmann <mpa at pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx25-karo-tx25.dts | 84 +++++++++++++++++++----------------
> >  1 file changed, 45 insertions(+), 39 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx25-karo-tx25.dts b/arch/arm/boot/dts/imx25-karo-tx25.dts
> > index 9b31faa96377..11344fb27727 100644
> > --- a/arch/arm/boot/dts/imx25-karo-tx25.dts
> > +++ b/arch/arm/boot/dts/imx25-karo-tx25.dts
> > @@ -42,49 +42,55 @@
> >  };
> >  
> >  &iomuxc {
> > -	pinctrl_uart1: uart1grp {
> > -		fsl,pins = <
> > -			MX25_PAD_UART1_TXD__UART1_TXD 0x80000000
> > -			MX25_PAD_UART1_RXD__UART1_RXD 0x80000000
> > -			MX25_PAD_UART1_CTS__UART1_CTS 0x80000000
> > -			MX25_PAD_UART1_RTS__UART1_RTS 0x80000000
> > -		>;
> > +	uart1 {
> Some other machines (e.g. imx51-babbage) use a big group named after the
> machine for all pin groups. Would it be nice to have a uniform rule
> here?

Oh yes, the majority seems to use this naming scheme now. I will change
it.

> 
> I think this grouping is a relict from the time when we considered to
> list the groups in the imx$num.dtsi? I would prefer to "fix" the driver
> to work with the way imx25-karo-tx25 presents the pinmuxing because I
> don't see the motivation for this extra grouping. (So let us define the
> current method of imx25-karo-tx25 as the good one to follow if you ask
> me.)

But the binding for the pinctrl unit is already defined. I am not sure
about the policy for changing devicetree bindings. I thought it should
be avoided?

Best regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150325/dab5eec7/attachment.sig>