[PATCH 7/7] common.c:105 Variable 'gephy' is never used.

Andrew Lunn andrew at lunn.ch
Fri Mar 13 07:08:00 PDT 2015


On Fri, Mar 13, 2015 at 03:44:24PM +0200, Ameen Ali wrote:
> Variable 'gephy' is assigned a value that is never used.
> 
> Signed-off-by : <AmeenALi023 at gmail.com>
> ---
>  arch/arm/mach-dove/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
> index 0d1a892..115a413 100644
> --- a/arch/arm/mach-dove/common.c
> +++ b/arch/arm/mach-dove/common.c
> @@ -113,7 +113,7 @@ static void __init dove_clk_init(void)
>  	orion_clkdev_add(NULL, "orion_spi.1", tclk);
>  	orion_clkdev_add(NULL, "orion_wdt", tclk);
>  	orion_clkdev_add(NULL, "mv64xxx_i2c.0", tclk);
> -
> +        orion_clkdev_add(NULL,"mv643xx_eth_port.0",gephy);

It looks like you have used spaces, not a tab?

Other than that, this looks sensible.

      Andrew

>  	orion_clkdev_add(NULL, "orion-ehci.0", usb0);
>  	orion_clkdev_add(NULL, "orion-ehci.1", usb1);
>  	orion_clkdev_add(NULL, "mv643xx_eth_port.0", ge);
> -- 
> 2.1.0
> 



More information about the linux-arm-kernel mailing list