[PATCH 3/8] ARM: make xscale iwmmxt code multiplatform aware

Robert Jarzmik robert.jarzmik at free.fr
Wed Mar 4 09:30:34 PST 2015


Arnd Bergmann <arnd at arndb.de> writes:

> On Wednesday 04 March 2015 15:12:02 Robert Jarzmik wrote:
>
> I tried to not change the behavior here, and I think you missed this part:
>
> -#if !defined(CONFIG_CPU_XSCALE) && !defined(CONFIG_CPU_XSC3)
> +#if !defined(CONFIG_CPU_XSCALE)
>  #define        cpu_is_xscale() 0
>  #else
> -#define        cpu_is_xscale() 1
>  ...
>
> This means that previously, cpu_is_xscale() returned true for pxa3xx,
> while now it returns false, and I added the "&& !cpu_is_xsc3()" to
> keep the logic the same as before.
>
> Does that make sense?
Ah now yes, I missed the former cpu_is_xscale() behavior, my brain is working in
first gear lately ...

Then the patch looks fine.

Cheers.

-- 
Robert



More information about the linux-arm-kernel mailing list