dma-mapping: support for DMA_ATTR_NON_CONSISTENT DMA attribute
mike.looijmans at topic.nl
Mon Jun 29 06:08:48 PDT 2015
On 29-06-15 11:45, Russell King - ARM Linux wrote:
> On Mon, Jun 29, 2015 at 08:44:50AM +0200, Mike Looijmans wrote:
>> On 29-06-15 07:24, Sylvain Munaut wrote:
>>> """ By using this API, you are guaranteeing to the platform that you
>>> have all the correct and necessary sync points for this memory in the
>>> driver should it choose to return non-consistent memory."""
>>> I had assumed it was the dma_sync_* calls, but apparently not.
>> I think the answer is "the dma_sync_* calls plus whatever it is your DMA
>> controller hardware needs to do"
> No it is not. When something is clearly the wrong API, you do not go
> around telling people to use it. I'm pretty disgusted that you think
> that is an appropraite way to behave.
I trying to merely refer to the "correct and necessary sync points" part, once
the decision to (properly) use the streaming API has been made.
To the best of my knowledge, the dma_sync_... methods take care of things from
the ARM (CPU) side.
That leaves only the device side, you need to make sure that for example its
FIFOs are empty before starting to flush caches. Something that the API cannot
do for you, but your driver and hardware (or logic in the case of a Zynq) must
do a proper job too.
Saying something about those things would make the documentation a lot less
cryptic than just dropping a "correct and necessary sync points" bomb into the
text and then offering no advise on where one could hope to find some clay
tablets with engravings explaining what is "correct and necessary".
More information about the linux-arm-kernel