[RFC PATCH] arm64: bpf: fix endianness conversion bugs

Alexei Starovoitov ast at plumgrid.com
Fri Jun 26 01:25:59 PDT 2015


On 6/25/15 6:39 PM, Xi Wang wrote:
> Upper bits should be zeroed in endianness conversion:
>
> - even when there's no need to change endianness (i.e., BPF_FROM_BE
>    on big endian or BPF_FROM_LE on little endian);
>
> - after rev16.
>
> This patch fixes such bugs by emitting extra instructions to clear
> upper bits.
>
> Cc: Zi Shen Lim<zlim.lnx at gmail.com>
> Cc: Alexei Starovoitov<ast at plumgrid.com>
> Fixes: e54bcde3d69d ("arm64: eBPF JIT compiler")
> Signed-off-by: Xi Wang<xi.wang at gmail.com>

Acked-by: Alexei Starovoitov <ast at plumgrid.com>

> The current testsuite catches the 16-bit bugs.  I'll send a separate
> patch that extends test_bpf to catch the 32-bit ones.

looking forward to it. Thanks.



More information about the linux-arm-kernel mailing list