[PATCH v2 1/3] net: mvneta: introduce compatible string "marvell, armada-xp-neta"
jason at lakedaemon.net
Thu Jun 25 06:20:09 PDT 2015
On Thu, Jun 25, 2015 at 11:13:23AM +0200, Simon Guinot wrote:
> On Fri, Jun 19, 2015 at 02:32:53PM +0200, Simon Guinot wrote:
> > On Wed, Jun 17, 2015 at 05:01:12PM +0000, Jason Cooper wrote:
> > > On Wed, Jun 17, 2015 at 05:15:28PM +0200, Gregory CLEMENT wrote:
> > > > On 17/06/2015 17:12, Gregory CLEMENT wrote:
> > > > > On 17/06/2015 15:19, Simon Guinot wrote:
> > > > >> The mvneta driver supports the Ethernet IP found in the Armada 370, XP,
> > > > >> 380 and 385 SoCs. Since at least one more hardware feature is available
> > > > >> for the Armada XP SoCs then a way to identify them is needed.
> > > > >>
> > > > >> This patch introduces a new compatible string "marvell,armada-xp-neta".
> > > > >
> > > > > Let's be future proof by going further. I would like to have an compatible string
> > > > > for each SoC even if we currently we don't use them.
> > >
> > > I disagree with this. We can't predict what incosistencies we'll discover in
> > > the future. We should only assign new compatible strings based on known IP
> > > variations when we discover them. This seems fraught with demons since we
> > > can't predict the scope of affected IP blocks (some steppings of one SoC, three
> > > SoCs plus two steppings of a fourth, etc)
> > >
> > > imho, the 'future-proofing' lies in being specific as to the naming of the
> > > compatible strings against known hardware variations at the time.
> > So, should I add more compatible strings or not ?
> How do you want me to handle this ? Did you reach an agreement ?
Sorry, this slipped off my radar. Probably EBKAC. :)
I'm still of the opinion that future-proofing equates to guessing.
It has the advantage of, if we guess correctly, things are easier down
the road when we discover differences between similar IP blocks.
However, if we guess incorrectly, then we have a mess on our hands.
iow, this proposal fails poorly.
I've no problem breaking DT compatibility when it's determined that we
made a mistake (or mistakes) in the past. See the irqchip rework that
Marc did a few cycles ago.
The difference here is that we know better. We *know* that dtbs are
upgraded with the kernel. We *know* that no one is shipping products
with dtbs in ROMs. So what are we really trying to protect against?
More information about the linux-arm-kernel