[PATCHv2 1/7] arm: perf: factor arm_pmu core out to drivers

Will Deacon will.deacon at arm.com
Tue Jun 16 09:17:28 PDT 2015


Hi Mark,

On Thu, Jun 11, 2015 at 05:44:14PM +0100, Mark Rutland wrote:
> To enable sharing of the arm_pmu code with arm64, this patch factors it
> out to drivers/perf/. A new drivers/perf directory is added for
> performance monitor drivers to live under.
> 
> MAINTAINERS is updated accordingly, with myself added as a reviewer as
> suggested by Will Deacon. The wildcard for arch/arm is updated to cover
> perf_regs.c and perf_callchain.c, which were added previously without a
> corresponding MAINTAINERS update.
> 
> Signed-off-by: Mark Rutland <mark.rutland at arm.com>
> Cc: Arnaldo Carvalho de Melo <acme at kernel.org>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: Ingo Molnar <mingo at redhat.com>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Paul Mackerras <paulus at samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra at chello.nl>
> Cc: Russell King <linux at arm.linux.org.uk>
> Cc: Will Deacon <will.deacon at arm.com>
> ---
>  MAINTAINERS                                                |  6 ++++--

Can you put the MAINTAINERS changes in a separate patch, please?

>  arch/arm/Kconfig                                           |  8 ++------
>  arch/arm/kernel/Makefile                                   |  3 +--
>  arch/arm/kernel/perf_event_v6.c                            |  2 +-
>  arch/arm/kernel/perf_event_v7.c                            |  2 +-
>  arch/arm/kernel/perf_event_xscale.c                        |  2 +-
>  arch/arm/mach-ux500/cpu-db8500.c                           |  2 +-
>  drivers/Kconfig                                            |  2 ++
>  drivers/Makefile                                           |  1 +
>  drivers/perf/Kconfig                                       | 14 ++++++++++++++
>  drivers/perf/Makefile                                      |  1 +
>  arch/arm/kernel/perf_event.c => drivers/perf/arm_pmu.c     |  2 +-
>  arch/arm/include/asm/pmu.h => include/linux/perf/arm_pmu.h |  4 ++--

I wonder whether that's such a good name for the subsystem. We already
have a bunch of perf_* headers directly under include/linux/ for the perf
core interfaces, so maybe drivers/pmu/ would be better?

Will



More information about the linux-arm-kernel mailing list