[PATCH] fixup! dmaengine: pxa_dma: add debug information

Robert Jarzmik robert.jarzmik at free.fr
Mon Jun 1 14:31:48 PDT 2015


Joe Perches <joe at perches.com> writes:

> Hello Robert.
>
> The return value of that dbg_show_requester_chan function
> was incorrect and the increment of pos was an example of
> why the seq_printf return value was changed to void.
>
> It was a pretty common error and easy to understand given
> the expectation that seq_printf should work like printf.
Sure.

> It's a pity it bit you. but this type of patch collision
> should be a bit more difficult to reoccur in the future.

I got what I deserved. I knew it was coming, I've seen it in other drivers of
mine, but my left brain didn't tell the other half to crosscheck in this
patch. Anyway, it's not a big fixup, so everything is fine now.

Cheers.


-- 
Robert



More information about the linux-arm-kernel mailing list