[PATCH 4/4] ARM: mvebu: add Device Tree description of RTC on Armada 38x

Arnaud Ebalard arno at natisbad.org
Tue Jan 13 15:03:12 PST 2015


Hi Gregory,

Gregory CLEMENT <gregory.clement at free-electrons.com> writes:

> The Marvell Armada 38x SoCs contains an RTC which differs from the RTC
> used in the other mvebu SoCs until now. This commit adds the Device
> Tree description of this interface at the SoC level.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement at free-electrons.com>
> ---
>  arch/arm/boot/dts/armada-38x.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index 04fe80d101f8..22909add8889 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -466,6 +466,12 @@
>  				clocks = <&gateclk 4>;
>  			};
>  
> +			rtc at 184a8 {
> +				compatible = "marvell,armada-380-rtc";
> +				reg = <0xa3800 0x20>, <0x184a0 0x0c>;
> +				interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> +			};
> +

Out of curiosity, why not naming the node rtc at a3800? Main argument:
least expectation principle when reading the .dtsi and expecting
increasing addresses. Or did I miss sth else?


>  			sata at a8000 {
>  				compatible = "marvell,armada-380-ahci";
>  				reg = <0xa8000 0x2000>;



More information about the linux-arm-kernel mailing list