[PATCH 2/4] ARM: sirf: add atlas7 machine support

Barry Song 21cnbao at gmail.com
Sat Jan 3 23:23:47 PST 2015


2014-12-31 6:34 GMT+08:00 Arnd Bergmann <arnd at arndb.de>:
> On Thursday 25 December 2014 16:34:18 Barry Song wrote:
>> +DT_MACHINE_START(ATLAS7_DT, "Generic ATLAS7 (Flattened Device Tree)")
>> +       /* Maintainer: Barry Song <baohua.song at csr.com> */
>> +       .smp            = smp_ops(sirfsoc_smp_ops),
>> +       .map_io         = sirfsoc_map_io,
>> +       .init_late      = sirfsoc_init_late,
>> +       .dt_compat      = atlas7_dt_match,
>> +MACHINE_END
>
> Can you check if the sirfsoc_map_io function is still required?
> My guess is that you can just replace sirfsoc_map_scu() with a
> call of ioremap in sirfsoc_smp_prepare_cpus, and drop sirfsoc_map_lluart()
> entirely in favor of the default debug_ll_io_init() function that
> is called when map_io is NULL.

after dropping MARCO,  i can simply delete sirfsoc_map_scu() as for
atlas7, this is not needed any more.
then finally, i can delete all sirfsoc_map_io() and DEBUG_LL mapping.

-barry



More information about the linux-arm-kernel mailing list