[PATCH 2/4] rtc: sa1100: convert to run-time register mapping

Robert Jarzmik robert.jarzmik at free.fr
Sat Feb 14 04:22:16 PST 2015


Rob Herring <robh at kernel.org> writes:

> SA1100 and PXA differ only in register offsets which are currently
> hardcoded in a machine specific header. Some arm64 platforms (PXA1928)
> have this RTC block also.
>
> Convert the driver to use ioremap and set the register offsets dynamically.
> Since we are touching all the register accesses, convert them all to
> readl/writel.

All right Rob, to conclude this discussion, provided you add to the git comment
what we discussed, ie. that this patch opens the path to exclusive runtime usage
between rtc-sa1100 and rtc-pxa on pxa, I'll ack it.

If somebody complains, I'll tell him to develop the glue between sa1100 and pxa
as Russell suggested, or use only one of the drivers.

Cheers.

--
Robert



More information about the linux-arm-kernel mailing list