[PATCH v2] ARM: smp: Only expose /sys/.../cpuX/online if hotpluggable

Magnus Damm magnus.damm at gmail.com
Sat Feb 14 02:01:22 PST 2015


Hi Russell,

On Fri, Feb 13, 2015 at 11:01 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Fri, Feb 13, 2015 at 09:44:50PM +0000, Magnus Damm wrote:
>> Also, based on the comment in mcpm_cpu_can_disable() it looks like the
>> PSCI hook may be executed once only with your change in place?
>> Hopefully PSCI is OK not being invoked for every CPU shutdown.
>
> This is why I've said (in the parent thread) that I'm not happy to
> apply this patch.  Mark Rutland has indicated that he has MCPM cases
> where the CPUs which can be disabled changes dynamically according
> to the secure firmware requirements, and ripping out todays
> infrastructure in light of that, only to have to add it back again
> later makes no sense.
>
> However, cleaning things up by removing unnecessary cpu_disable
> methods is a good thing to do irrespective of that.

I completely agree!

Cheers,

/ magnus



More information about the linux-arm-kernel mailing list