[PATCH] clocksource: mark sched_clock_read functions notrace

Josh Cartwright joshc at ni.com
Mon Feb 9 11:18:59 PST 2015


On Fri, Feb 06, 2015 at 03:31:03PM -0600, Nathan Sullivan wrote:
> On Tue, Feb 03, 2015 at 02:13:26PM -0600, Josh Cartwright wrote:
> > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> > > index 095c177..df5af55 100644
> > > --- a/drivers/clocksource/arm_arch_timer.c
> > > +++ b/drivers/clocksource/arm_arch_timer.c
> > > @@ -405,7 +405,7 @@ u32 arch_timer_get_rate(void)
> > >  	return arch_timer_rate;
> > >  }
> > >  
> > > -static u64 arch_counter_get_cntvct_mem(void)
> > > +static u64 notrace arch_counter_get_cntvct_mem(void)
> > 
> > Assuming you're trying to mark all sched_clock() implementations
> > notrace, then you missed a few: arch_counter_get_cntvct and
> > arch_counter_get_cntpct.
> > 
> >   Josh
> 
> Hmm, those are inlined.  Should I still mark them notrace?

There's necessarily an out-of-line version of these functions generated,
as arch_timer_read_counter has to point at something, so yes, I'd say
so.

  Josh



More information about the linux-arm-kernel mailing list