[PATCH 2/4] rtc: sa1100: convert to run-time register mapping

[Rob Herring]

On Wed, Feb 4, 2015 at 7:25 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Tuesday 03 February 2015 17:22:53 Rob Herring wrote:
>> SA1100 and PXA differ only in register offsets which are currently
>> hardcoded in a machine specific header. Some arm64 platforms (PXA1928)
>> have this RTC block also.
>>
>> Convert the driver to use ioremap and set the register offsets dynamically.
>> Since we are touching all the register accesses, convert them all to
>> readl/writel.
>>
>> Signed-off-by: Rob Herring <robh at kernel.org>
>> Cc: Alessandro Zummo <a.zummo at towertech.it>
>> Cc: rtc-linux at googlegroups.com
>
> Hmm, I really should have sent out my version of the patch ages ago. :(

Got any others? :)

>
> Can you have a look at
>
> http://git.kernel.org/cgit/linux/kernel/git/arnd/playground.git/commit/?h=multiplatform-3.19-next&id=4d9727883a363fb839e7d1633599166c0a08d644
>
> to see compare the approaches and see if there is anything I did that you
> missed?

You used the relaxed variants seems to be the main difference. Yours
won't build on arm64 either.

Rob