usb: wrong compatible string for MX23?

Stefan Wahren stefan.wahren at i2se.com
Mon Dec 28 15:45:51 PST 2015


Hi Peter,

i was inspired by the discussion about the USB runtime suspend issue on MX28. I
think i've found another issue.
In the dtsi for the MX23 the usb node has the following compatible:

usb0: usb at 80080000 {
        compatible = "fsl,imx23-usb", "fsl,imx27-usb";
...

But in ci_hdrc_imx.c there is only "fsl,imx27-usb" and "fsl,imx28-usb" defined.

So in case of a MX23 board it would fallback to "fsl,imx27-usb", which is IMHO
not correct.

Which way to fix this issue would you suggest:

a) extend ci_hdrc_imx.c and the binding by copying the imx28 platform and name
it imx23

b) rename the compatible string from "fsl,imx23-usb" to "fsl-imx28-usb"

Best regards
Stefan



More information about the linux-arm-kernel mailing list