[PATCH v2 5/7] ARM: sun8i: Add clock indices

[Chen-Yu Tsai]

On Wed, Aug 12, 2015 at 1:50 AM, Michael Turquette
<mturquette at baylibre.com> wrote:
> Quoting Chen-Yu Tsai (2015-08-10 21:49:54)
>> On Sat, Aug 8, 2015 at 12:21 AM, Chen-Yu Tsai <wens at csie.org> wrote:
>> > On Sat, Aug 1, 2015 at 1:46 AM, Maxime Ripard
>> > <maxime.ripard at free-electrons.com> wrote:
>> >> The A23 and A33 gates have a non continuous set of clock IDs that are
>> >> valid. Add the clock-indices property to the DT to express this.
>> >>
>> >> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
>> >> ---
>> >>  arch/arm/boot/dts/sun8i-a23-a33.dtsi | 15 +++++++++++++++
>> >>  1 file changed, 15 insertions(+)
>> >>
>> >> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
>> >> index 7abd0ae3143d..c318c770b6c1 100644
>> >> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
>> >> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
>> >> @@ -180,6 +180,15 @@
>> >>                         compatible = "allwinner,sun8i-a23-ahb1-gates-clk";
>> >>                         reg = <0x01c20060 0x8>;
>> >>                         clocks = <&ahb1>;
>> >> +                       clock-indices = <1>, <6>,
>> >
>> > Turns out the A33 (and I assume the same with the A23) has
>> > an ahb1 clock gate for the Security System at clock-index <5>.
>>
>> Looks like the A23 does not have this one, nor the SS mod clock.
>>
>> > This is found in the updated A33 user manual.
>> >
>> >> +                                       <8>, <9>, <10>,
>> >> +                                       <13>, <14>,
>> >> +                                       <19>, <20>,
>> >> +                                       <21>, <24>, <26>,
>> >> +                                       <29>, <32>, <36>,
>> >> +                                       <40>, <44>, <46>,
>> >> +                                       <52>, <54>,
>> >
>> > <53> is ahb1 clock gate for msgbox, again found in A33 manual.
>>
>> A23 has this one. Found in Allwinner kernel sources.
>>
>> >> +                                       <57>;
>> >
>> > <58> is ahb1 clock gate for SAT, which seems to be part of the
>> > display pipeline.
>>
>> This one is A33 only.
>>
>> I guess we should do a separate compatible for A33 AHB1 clock gates.
>
> ChenYu,
>
> I believe Maxime is on vacation. I told him that I would pick these
> patches directly. It looks like your comments can be fixed up in
> follow-up patches at a later date, correct?

That's right. I was mostly asking how to proceed with adding them.

> If so then I will apply them to clk-next.

Please do. (I see they are already in.)

Thanks
ChenYu


> Regards,
> Mike
>
>>
>> ChenYu
>>
>> >>                         clock-output-names = "ahb1_mipidsi", "ahb1_dma",
>> >>                                         "ahb1_mmc0", "ahb1_mmc1", "ahb1_mmc2",
>> >>                                         "ahb1_nand", "ahb1_sdram",
>> >> @@ -196,6 +205,8 @@
>> >>                         compatible = "allwinner,sun8i-a23-apb1-gates-clk";
>> >>                         reg = <0x01c20068 0x4>;
>> >>                         clocks = <&apb1>;
>> >> +                       clock-indices = <0>, <5>,
>> >> +                                       <12>, <13>;
>> >>                         clock-output-names = "apb1_codec", "apb1_pio",
>> >>                                         "apb1_daudio0", "apb1_daudio1";
>> >>                 };
>> >> @@ -213,6 +224,10 @@
>> >>                         compatible = "allwinner,sun8i-a23-apb2-gates-clk";
>> >>                         reg = <0x01c2006c 0x4>;
>> >>                         clocks = <&apb2>;
>> >> +                       clock-indices = <0>, <1>,
>> >> +                                       <2>, <16>,
>> >> +                                       <17>, <18>,
>> >> +                                       <19>, <20>;
>> >>                         clock-output-names = "apb2_i2c0", "apb2_i2c1",
>> >>                                         "apb2_i2c2", "apb2_uart0",
>> >>                                         "apb2_uart1", "apb2_uart2",
>> >> --
>> >> 2.4.6
>> >>
>> >
>> > Not sure if you want to add the clocks I mentioned together
>> > in this patch, or do a separate patch.
>> >
>> > The rest look good.
>> >
>> > ChenYu
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel