[PATCH 0/2] drivers: PL061: Add platform driver probing support

Greg Kroah-Hartman gregkh at linuxfoundation.org
Mon Aug 3 09:26:23 PDT 2015


On Mon, Aug 03, 2015 at 10:49:23AM +0100, Russell King - ARM Linux wrote:
> On Mon, Aug 03, 2015 at 05:26:05PM +0800, Shannon Zhao wrote:
> > Hi Russell,
> > 
> > On 2015/8/3 15:58, Russell King - ARM Linux wrote:
> > > On Mon, Aug 03, 2015 at 02:59:56PM +0800, Shannon Zhao wrote:
> > >> From: Shannon Zhao <shannon.zhao at linaro.org>
> > >>
> > >> According to ACPI SPEC, it supports ARM boards to use "GPIO-signaled
> > >> ACPI Events". These events can be used for input events. And to QEMU, it
> > >> uses GPIO PL061 controller for input events.
> > >>
> > >> These two patches add platform driver support for PL061 probed by DT or
> > >> ACPI.
> > > 
> > > This certainly is incorrect for DT, and is probably wrong for ACPI too.
> > > DT creates amba devices, so binds via the amba device driver.
> > > 
> > 
> > Oh, sorry. The changes for DT are not necessary. But for ACPI I think it
> > needs to convert pl061 to platform device since ACPI doesn't support
> > AMBA devices. The Pl011 also does the same thing to support ACPI
> > probing. See drivers/tty/serial/amba-pl011.c
> 
> Maybe rather than having every AMBA driver also converted to a platform
> driver (which GregKH hates) maybe ACPI should support the AMBA bus
> instead?
> 
> Greg?

The ACPI developers have been doing work to allow a driver to handle
getting the resources from either DT or ACPI no matter what bus it is
on, so converting anything to a platform driver shouldn't be needed.

but I don't really know the details here, and this isn't being sent to
the ACPI mailing list, so I don't know what to suggest...

greg k-h



More information about the linux-arm-kernel mailing list