[PATCH 3/4] ARM: nomadik: move l2x0 setup to device tree

Russell King - ARM Linux linux at arm.linux.org.uk
Sun Aug 2 15:06:26 PDT 2015


On Sun, Aug 02, 2015 at 11:56:33PM +0200, Linus Walleij wrote:
> -	/* At full speed latency must be >=2, so 0x249 in low bits */
> -	.l2c_aux_val	= 0x00700249,
> -	.l2c_aux_mask	= 0xfe0fefff,
> +	.l2c_aux_val	= 0x0,
> +	.l2c_aux_mask	= ~0x0UL,

It always amazes me by the things people come up with... what prompted
the addition of "UL" on that constant?  Why do you think it needs it?

A simple:

	.l2c_aux_val	= 0,
	.l2c_aux_mask	= ~0,

will suffice.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.



More information about the linux-arm-kernel mailing list