[PATCHv7 7/8] watchdog: omap_wdt: Fix memory leak on probe fail

Timo Kokkonen timo.kokkonen at offcode.fi
Sun Apr 26 22:50:02 PDT 2015


On 26.04.2015 18:32, Guenter Roeck wrote:
> On 04/22/2015 04:11 AM, Timo Kokkonen wrote:
>> Structures allocated on the beginning of the probe function must be
>> freed in case of failure.
>
> Really ? The functions are allocated with devm_kzalloc.
> It might be useful to introduce an error on purpose, have the code
> jump to your new label, and observe what happens.

Interesting. I wasn't aware of devm_kzalloc. I will have to remove this 
patch from the series and rework the another omap patch to apply without 
this. Thanks!

-Timo



More information about the linux-arm-kernel mailing list