[PATCH] bus: omap_l3_noc: Fix master id address decoding for OMAP5

Nishanth Menon nm at ti.com
Fri Apr 24 12:55:52 PDT 2015


On 04/24/2015 02:54 PM, Suman Anna wrote:
> On 04/24/2015 02:38 PM, Nishanth Menon wrote:
>> On Fri, Apr 24, 2015 at 2:10 PM, Suman Anna <s-anna at ti.com> wrote:
>>> On 04/24/2015 01:33 PM, Nishanth Menon wrote:
>>>> On 04/24/2015 12:54 PM, Suman Anna wrote:
>>
>> ...
>>>>> -static struct l3_target_data omap_l3_target_data_clk3[] = {
>>>>> -    {0x0100, "EMUSS",},
>>>>> -    {0x0300, "DEBUG SOURCE",},
>>>>> -    {0x0,   "HOST CLK3",},
>> ^^ this was HOST CLK3
>> ..
>>>>>
>>>>> +/* OMAP5 data */
>>>>> +static struct l3_target_data omap5_l3_target_data_clk3[] = {
>>>>> +    {0x0100, "L3INSTR",},
>>>>> +    {0x0300, "DEBUGSS",},
>>>>> +    {0x0,    "HOSTCLK3",},
>>>>
>>>> "HOST CLK"
>>>
>>> Why? I followed the convention used for the other two HOST CLKs for the
>>
>> so asked, if it should be HOST<space>CLK3
> 
> Aah ok, you missed the trailing number before. In anycase, this was

Sorry about that..

> intentional to match HOSTCLK1 and HOSTCLK2 on OMAP4/5. Overall, the
> names are somewhat non-standard, some use underscores and some others
> strip out the underscore and do not use any spaces in between either.
> "HOST CLK3" would be the only one to use a space for OMAP4, so I got rid
> of it, so hope that's ok with you.

would have been nice to cover that in commit message. no biggie for me.


-- 
Regards,
Nishanth Menon



More information about the linux-arm-kernel mailing list