[PATCH] mmc: core: add missing pm event in mmc_pm_notify to fix hib restore

Grygorii.Strashko@linaro.org grygorii.strashko at linaro.org
Fri Apr 24 03:52:15 PDT 2015


On 04/23/2015 04:19 PM, Ulf Hansson wrote:
> On 23 April 2015 at 12:43,  <grygorii.strashko at linaro.org> wrote:
>> From: Grygorii Strashko <Grygorii.Strashko at linaro.org>
>>
>> The PM_RESTORE_PREPARE is not handled now in mmc_pm_notify(),
>> as result mmc_rescan() could be scheduled and executed at
>> late hibernation restore stages when MMC device is suspended
>> already - which, in turn, will lead to system crash on TI dra7-evm board:
>>
>> WARNING: CPU: 0 PID: 3188 at drivers/bus/omap_l3_noc.c:148 l3_interrupt_handler+0x258/0x374()
>> 44000000.ocp:L3 Custom Error: MASTER MPU TARGET L4_PER1_P3 (Idle): Data Access in User mode during Functional access
>>
>> Hence, add missed PM_RESTORE_PREPARE PM event in mmc_pm_notify().
>>
>> Signed-off-by: Grygorii Strashko <Grygorii.Strashko at linaro.org>
> 
> Huh, that was an old bug you found. :-)

oh yes. it's happened thanks to HW issue on my board which
generates a flood of SDCD IRQs :)

It's the worst case ever to track wrong/missed PM notifiers (

> 
> I have applied it for fixes and added the below fixes tag.
> 
> Fixes: 4c2ef25fe0b8 (mmc: fix all hangs related to mmc/sd card
> insert/removal during suspend/resume)

Thanks. 

-- 
regards,
-grygorii



More information about the linux-arm-kernel mailing list