[PATCH] ASoC: samsung: s3c24xx-i2s: Fix return value check in s3c24xx_iis_dev_probe()

Krzysztof Kozłowski k.kozlowski.k at gmail.com
Thu Apr 16 05:24:03 PDT 2015


2015-04-16 21:18 GMT+09:00  <weiyj_lk at 163.com>:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_resource() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> ---
>  sound/soc/samsung/s3c24xx-i2s.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Good catch.

Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k at gmail.com>

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list