[PATCH 1/6] ARM: lpc18xx: add basic support for NXP LPC18xx/43xx SoCs

Arnd Bergmann arnd at arndb.de
Thu Apr 9 13:23:02 PDT 2015


On Thursday 02 April 2015 19:25:35 Ezequiel Garcia wrote:
> On 04/02/2015 01:48 PM, Joachim Eastwood wrote:
> > On 2 April 2015 at 16:21, Arnd Bergmann <arnd at arndb.de> wrote:
> >> On Wednesday 01 April 2015 23:20:38 Joachim Eastwood wrote:
> >>> +static const char *const lpc18xx_43xx_compat[] __initconst = {
> >>> +       "ea,lpc4357-developers-kit",
> >>> +       NULL
> >>>
> >>
> >> I don't see 'ea' in Documentation/devicetree/bindings/vendor-prefixes.txt,
> >> can you add a patch for that?
> > 
> > Sure. I'll add it to the next version.
> > 
> >> It's probably better to make the string we match against the most
> >> generic one here, so we don't have to update the list for every
> >> new dts file that gets added.
> > 
> > Okey.
> > 
> > Could I just use a SoC string here (like "nxp.lpc1850")?
> > 
> 
> Yeah, that should work. Or maybe you can use "nxp,lpc18xx" and use that
> compatible as a generic compatible for all LPC18xx/LPC43xx MCUs.
> 

Sorry for the late follow-up. nxp,lpc18xx would not be appropriate here,
because compatible strings are supposed to be specific models, not wildcards.
nxp,lpc1850 is fine.

	Arnd



More information about the linux-arm-kernel mailing list