[PATCH] coresight: etb10: Print size of buffer we fail to allocate

Mathieu Poirier mathieu.poirier at linaro.org
Thu Apr 9 08:14:40 PDT 2015


On 9 April 2015 at 08:55, Mark Brown <broonie at kernel.org> wrote:
> On Thu, Apr 09, 2015 at 08:46:55AM -0600, Mathieu Poirier wrote:
>
>> I'll take this patch but will rework the commit message a little.  If
>> the power domains are not setup properly the device won't show up on
>> AMBA and as such won't get probed.
>
> This depends on what the hardware does and how the device is registered
> - if the device is registered with an ID provided (which you can do)
> then AMBA won't bother reading the ID back and verifying that it's
> correct so there's no interaction with the hardware until we hit the
> driver.

Indeed possible, but in that case you'll get a core dump or the kernel
will simply hang waiting on the memory area being read.

>
> I've not checked the DT case, though it doesn't seem like there's any
> check that the compatible string matches the ID read from the hardware
> which is a bit interesting...

This is something I've been meaning to add for a while now but never
got around to do it.



More information about the linux-arm-kernel mailing list