[PATCH v8 2/2] ARM: EXYNOS: Move PMU specific definitions from common.h

Pankaj Dubey pankaj.dubey at samsung.com
Tue Sep 30 19:59:16 PDT 2014


Hi Arnd,

On Tuesday, September 30, 2014 4:09 PM, Arnd Bergmann wrote,
> To: linux-arm-kernel at lists.infradead.org
> Cc: Pankaj Dubey; linux-kernel at vger.kernel.org;
linux-samsung-soc at vger.kernel.org;
> kgene.kim at samsung.com; linux at arm.linux.org.uk; naushad at samsung.com;
> tomasz.figa at gmail.com; thomas.ab at samsung.com; vikas.sajjan at samsung.com
> Subject: Re: [PATCH v8 2/2] ARM: EXYNOS: Move PMU specific definitions
from
> common.h
> 
> On Tuesday 30 September 2014 15:51:21 Pankaj Dubey wrote:
> >
> > +static inline void pmu_raw_writel(u32 val, u32 offset) {
> > +       __raw_writel(val, pmu_base_addr + offset); }
> > +
> > +static inline u32 pmu_raw_readl(u32 offset) {
> > +       return __raw_readl(pmu_base_addr + offset); }
> > +
> >
> 
> While you're at it, please convert these to use readl_relaxed() instead,
which is safe to
> use in drivers and works independent of CPU endianess.
> 

OK, I will update this. 

Thanks,
Pankaj Dubey
> 	Arnd




More information about the linux-arm-kernel mailing list