[PATCH v2 00/11] ARM: shmobile: r8a7740/armadillo800eva legacy PM domain support

Geert Uytterhoeven geert at linux-m68k.org
Tue Sep 30 00:28:40 PDT 2014


Hi Magnus,

On Tue, Sep 30, 2014 at 9:22 AM, Magnus Damm <magnus.damm at gmail.com> wrote:
>>>> There are a few dependencies to make resume from s2ram work:
>>>>   - "[PATCH/RFC] fbdev: sh_mobile_hdmi: Re-init regs before irq re-enable on
>>>>     resume",
>>>>   - "[PATCH] ARM: hw_breakpoint: Trap undef instruction exceptions on wake-up",
>>>>     or an alternative solution.
>>>>
>>>> Apart from that, I'm not aware of any regressions (except perhaps for USB,
>>>> which I was unable to get working anyway).
>>>
>>> Hi Geert,
>>>
>>> what is your feeling about (me) queueing up part of all of this series now?
>>
>> If you (Magnus?) can live with non-working resume from s2ram for now,
>> it can be queued for v3.19.
>
> If the series as a whole introduces a known regression then I think we
> should only merge the portions that work without introducing some
> issue.
>
>> I don't think I can improve on the HDMI fix without getting docs and spending
>> (much) time to get HDMI working on Armadillo.
>
> Ok, and I suspect it is quite unlikely we will receive any improved
> docs for r8a7740.

So I will resubmit the HDMI fix.

>> The hw_breakpoint fix has to be replaced by something better/acceptable,
>> I'm working on that.
>
> Thanks!
>
> So what is a good way to proceed with this series I wonder?

There are two options:
  1. Drop the two patches that introduce the D4 and A4MP PM domains,
  2. Amend the patches that introduce the D4 and A4MP PM domains to
     comment out the entries in the table in pm-r8a7740.c, like was done in
     the first submission.

Both will cause conflicts when applying the successive patches.

If you don't care about bisectability, you can implement option 2 as a
separate change, after applying the whole series.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



More information about the linux-arm-kernel mailing list