[PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

Wolfram Sang wsa at the-dreams.de
Mon Sep 29 03:13:19 PDT 2014


> >+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> 
> Error checking on *res*...?
> 
> We should *return* on platform_get_resource() failure..
> 
> >+	base = devm_ioremap_resource(&pdev->dev, res);

Nope. devm_ioremap_resource does that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140929/52c56035/attachment.sig>


More information about the linux-arm-kernel mailing list