[PATCHv4 2/6] ARM: dts: Add initial LS1021A QDS board dts support

Li.Xiubo at freescale.com Li.Xiubo at freescale.com
Fri Sep 26 00:51:15 PDT 2014


Hi,

[...]
> > +
> > +	soc {
> > +		leds {
> 
> I think leds are board level devices and do not have to be under node
> "soc"?
> 
@Shawn,
Yes, it is.

@Jingchang,
For now we could just remove the led nodes here. There hasn't any real leds
On QDS(and for now we have to test their output pulse).

So this could be added later when need.

> > +			compatible = "pwm-leds";
> 
> Please have a new line between property list and device node ...
> 
This and the following issues about led will be fixed when adding this node separately
In the future.

[...]

Thanks,

BRs
Xiubo



More information about the linux-arm-kernel mailing list