[PATCH RESEND v5 1/5] usb: host: ehci-st: Add EHCI support for ST STB devices

Arnd Bergmann arnd at arndb.de
Fri Sep 5 10:57:28 PDT 2014


On Friday 05 September 2014 18:23:45 Peter Griffin wrote:
> +struct st_platform_priv {
> +       struct clk *clks[USB_MAX_CLKS];
> +       struct clk *clk48;
> +       struct reset_control *rst;
> +       struct reset_control *pwr;
> +       struct phy *phy;
> +};

Any reason why this is in a shared header file? It looks like
duplicating the structure under two different names would
actually be shorter and keep the drivers more readable as they'd
be self-contained, even when they have the exact same structure.

Do both drivers use all fields?

	Arnd



More information about the linux-arm-kernel mailing list