[PATCH v5 5/6] drivers: soc: exynos-pmu: Add support for Exynos7

Kukjin Kim kgene at kernel.org
Sat Nov 29 15:35:26 PST 2014


Amit Daniel Kachhap wrote:
> 
> Add PMU settings for exynos7. This is required for future suspend-to-ram,
> cpuidle and power domain support.
> 
> Note: In this patch some static declarations lines are over 80
> characters per line for easy redability.
> 
> Reviewed-by: Pankaj Dubey <pankaj.dubey at samsung.com>
> Signed-off-by: Eunseok Choi <es10.choi at samsung.com>
> Signed-off-by: Abhilash Kesavan <a.kesavan at samsung.com>
> Signed-off-by: Amit Daniel Kachhap <amit.daniel at samsung.com>
> ---
>  drivers/soc/samsung/exynos-pmu.c            |  427 ++++++++++++++++++++++++++-
>  include/linux/soc/samsung/exynos-regs-pmu.h |  273 +++++++++++++++++
>  2 files changed, 699 insertions(+), 1 deletion(-)
> 
I'm not sure all of the definitions in exynos-regs-pmu are required?...too many,
and I couldn't check the addresses are correct ;)

And how about splitting to each SoC specific file in drivers/soc/samsung/ ?
For example, exynos-pmu.c and exynos7-pmu.c like cpufreq...? Just considering.

- Kukjin




More information about the linux-arm-kernel mailing list