[PATCH v2] ARM: dt: fix up PL011 device tree bindings

Grant Likely grant.likely at linaro.org
Thu Nov 27 06:00:45 PST 2014


On Thu, Nov 27, 2014 at 1:40 PM, Linus Walleij <linus.walleij at linaro.org> wrote:
> On Mon, May 12, 2014 at 11:37 AM, Linus Walleij
> <linus.walleij at linaro.org> wrote:
>
>> Make the map match the reality, the current binding text is
>> nonsense:
>>
>> - The clock required for the clocking of the serial port
>>   must come first and is not optional (as the driver will
>>   otherwise proceed to grab and use the apb_pclk as uartclk),
>>   and the apb_pclk that clocks the logic must come second
>>   as the code will retrieve the first clock by index,
>>   whereas the PrimeCell but will explicitly look for
>>   "apb_pclk" so this can be specified later, as it is
>>   looked up by name.
>>
>> - The pin control state "default" is the only mandated
>>   state, the sleep state is entirely optional.
>>
>> We also add an example to avoid further confusion.
>>
>> Reported-by: Arnd Bergmann <arnd at arndb.de>
>> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
>> ---
>> ChangeLog v1->v2:
>> - Rename amba_pclk to apb_pclk
>> - Split clock/clocks properties and indicate that listin one
>>   clock only is deprecated
>
> PING on this, 6 months and the bindings still look like hell.
>
> Greg can you pick this up through the serial tree?
>
> I can resend the patch if you don't have it...

Ugh, sorry. I'll merge it in my tree right now.

g.

>
> Yours,
> Linus Walleij



More information about the linux-arm-kernel mailing list