[PATCH 2/2 v2] SPI: spi-pxa2xx: SPI support for Intel Quark X1000
broonie at kernel.org
Tue Nov 25 13:02:22 PST 2014
On Tue, Nov 25, 2014 at 12:06:41PM -0800, Olof Johansson wrote:
> On Mon, Sep 29, 2014 at 7:22 AM, Weike Chen <alvin.chen at intel.com> wrote:
> > This piece of work is derived from Dan O'Donovan's initial work for Intel Quark
> > X1000 SPI enabling.
> How about build testing for other platforms that share this driver
> when you make changes to it? This is obviously completely broken.
> Doing these constants under ifdef seems fragile at best, braindead at
> worst. Please don't proliferate that coding style.
> Mark, can you revert until Intel learns how to play well with others?
> This is from a pxa3xx-defconfig build:
Ugh, why does this driver not have a COMPILE_TEST dependency? Not that
it'd have caught this one.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 473 bytes
Desc: Digital signature
More information about the linux-arm-kernel