[PATCH v2 1/3] pinctrl: Add Qualcomm TLMM driver
timur at codeaurora.org
Tue Nov 25 11:55:53 PST 2014
On Thu, Dec 5, 2013 at 8:10 PM, Bjorn Andersson
<bjorn.andersson at sonymobile.com> wrote:
> +static int msm_gpio_init(struct msm_pinctrl *pctrl)
> + struct gpio_chip *chip;
> + int irq;
> + int ret;
> + int i;
> + int r;
> + chip = &pctrl->chip;
> + chip->base = 0;
> + chip->ngpio = pctrl->soc->ngpios;
I know this patch is a year old, but I'm wondering if this line is correct.
The original version of your patch from 11/23/13 said this:
+ chip->ngpio = pctrl->soc->gpio_range->npins;
and today, the line is this:
unsigned ngpio = pctrl->soc->ngpios;
I'm wondering if this line should be instead:
unsigned ngpio = pctrl->soc->npins;
I'm confused about the difference between msm_pinctrl_soc_data.npins
and msm_pinctrl_soc_data.ngpios. Variable "ngpio" is used by
gpiochip_add(), so I think it's not concerned with pin control.
msm_pinctrl_soc_data.npins appears to be the number of GPIOs, whereas
msm_pinctrl_soc_data.ngpios appears to be the number of pin groups.
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
More information about the linux-arm-kernel