[PATCH v11 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420
sudeep.holla at arm.com
Mon Nov 24 05:44:44 PST 2014
On 20/11/14 03:48, Viresh Kumar wrote:
> Oh, you are still alive? I thought you were about to get married :)
> Just kidding !!
> On 20 November 2014 00:58, Sudeep Holla <sudeep.holla at arm.com> wrote:
>> Sorry for raising this issue always with Exynos cpufreq drivers. IMO the
>> bindings for "arm-bL-cpufreq-dt" is broken. Currently no one is using it
>> and it's better to fix it before we have a real user of it.
> Hmm, yeah if we can. I haven't found a easy way to go ahead and then
> got caught in other activities.
Agreed, it's not easy but needs to be fixed :)
>> If you look at the binding document for it, it has a fixme which
>> shouldn't have been there at first place. It assumes the ordering of
>> CPU's specified in the DT and the logical index allocation to them.
> Ok, I believe the FIXME is a bit outdated. From the code I can see only
> this limitation.
> - For every cluster, the cpu which boots up first should carry the OPPs.
> Otherwise there is no restriction on ordering of CPUs.
Not entirely true, it assuming the fact that the logical index provided
by the OS is completely based on the ordering in the DT.
> - I believe CPUs boot in the order they are present in DT except for the
> boot CPU. So, the first node for every cluster should have it.
> Correct ? Then we can update the fixme.
No, I disagree as you trying to implicitly depend on the logic Linux
uses to assign logical index. It can be changed any time, and depending
on it might break things in future which can't be fixed easily later
especially if it's DT related.
>> It even breaks for hotplug especially if you hotplug-in back in
>> different order.
> Hmm, I never thought about it. But yes the CPU with the OPPs should
> be the first one to come back.
How can you assume that ? I can write a simple test which hot-plugs out
all the CPUs in the (esp. multi-cluster) system in ascending order of
logical index and hot-plug back in descending order. Then the above
>> We can work around that probably, but it's better to
>> fix the binding. I failed to grab much attention in my previous attempts
>> to address this. Viresh also started a discussion more recently.
> They are just stuck and went nowhere :(
The platforms needing it have to get involved in such discussions to
make any progress.
More information about the linux-arm-kernel