[PATCH 3/3] memory: gpmc: Move omap gpmc code to live under drivers

Tony Lindgren tony at atomide.com
Fri Nov 21 10:45:34 PST 2014


* Felipe Balbi <balbi at ti.com> [141121 10:40]:
> On Fri, Nov 21, 2014 at 10:34:16AM -0800, Tony Lindgren wrote:
> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -41,6 +41,14 @@ config TI_EMIF
> >  	  parameters and other settings during frequency, voltage and
> >  	  temperature changes
> >  
> > +config OMAP_GPMC
> > +	bool
> 
> shouldn't you make this selectable ? I might want to build a kernel
> without GPMC support because my board just doesn't use GPMC :-)

Eventually yes, but let's keep it separate from this move. We'd have
to do something like this:

- Make omap MTD drivers depend on OMAP_GPMC

- Make tusb6010 depend on OMAP_GPMC

- Make smc911x depend on OMAP_GPMC

- Build arch/arm/mach-omap2/*gpmc*.c conditionally
  depending on OMAP_GPMC

Adding stubs for omap-gpmc probably does not make sense as these
devices really depend on GPMC.

Regards,

Tony



More information about the linux-arm-kernel mailing list