[PATCH RFC 3/3] ARM: dts: enable power subsystem for i.MX28

Stefan Wahren stefan.wahren at i2se.com
Thu Nov 20 14:57:03 PST 2014


Hi Fabio,

> Fabio Estevam <festevam at gmail.com> hat am 20. November 2014 um 22:32
> geschrieben:
>
>
> Hi Stefan,
>
> On Thu, Nov 20, 2014 at 6:14 PM, Stefan Wahren <stefan.wahren at i2se.com> wrote:
> > This patch enables the power subsystem for all i.MX28 boards.
> >
> > Signed-off-by: Stefan Wahren <stefan.wahren at i2se.com>
> > ---
> > arch/arm/boot/dts/imx28.dtsi | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 47f68ac..5c163a5 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -1022,8 +1022,12 @@
> > };
> >
> > power: power at 80044000 {
> > + compatible = "fsl,imx28-power";
>
> Should we have 'fsl,imx23-power' and 'fsl,imx28-power' as compatible strings?

yes, of course.

>
> Or ''fsl,mxs-power' could be used for both?

I think that would be a bad idea. I can't believe that all PMU register of
i.MX23 and i.MX28 are identical. So in the future we will have to distinguish
between them. It's better to do it now like most of the mxs driver does.

Stefan



More information about the linux-arm-kernel mailing list