[PATCH 1/2] ARM: imx: Remove unneeded .map_io initialization
geert at linux-m68k.org
Wed Nov 19 05:17:10 PST 2014
On Fri, Nov 14, 2014 at 5:02 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Fri, Nov 14, 2014 at 04:53:57PM +0100, Geert Uytterhoeven wrote:
>> If machine_desc.map_io is not set, devicemaps_init() in the common ARM
>> code will call debug_ll_io_init().
> How about a WARN_ON(mdesc->map_io == debug_ll_io_init) ? This can only
> really be done when CONFIG_DEBUG_LL is defined because otherwise it's an
> inline function, but it may help to stop these from appearing in the
> first place.
I'd rather have a BUILD_BUG_ON(). Unfortunately MACHINE_END doesn't
know about the machine type, else we could probably add a check to that
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
More information about the linux-arm-kernel