[PATCH] gpio: mxs: implement get_direction callback

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Sun Nov 16 13:48:38 PST 2014

Hello again,

On Sun, Nov 16, 2014 at 10:42:39PM +0100, Uwe Kleine-König wrote:
> Also note that the atmel_get_lines_status function can be simplified to
> just:
> 	status = UART_GET_CSR(port);
> 	return mctrl_gpio_get(atmel_port->gpios, &status);
thinking again, this is wrong because it uses the Atmel specific
register bits for the different flags, but with the generic solution
outlined in the previous mail this function wouldn't need to handle the
gpio parts at all.

Best regards

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

More information about the linux-arm-kernel mailing list