[PATCH v2] can: Fix bug in suspend/resume
mkl at pengutronix.de
Fri Nov 14 00:54:37 PST 2014
On 11/14/2014 09:16 AM, Kedareswara rao Appana wrote:
> The drvdata in the suspend/resume is of type struct net_device,
> not the platform device.Enable the clocks in the suspend before
> accessing the registers of the CAN.
> Signed-off-by: Kedareswara rao Appana <appanad at xilinx.com>
> Changes for v2:
> - Removed the struct platform_device* from suspend/resume
> as suggest by Lothar.
> - The clocks are getting disabled and un prepared at the end of the probe.
> In the suspend the driver is doing a register write.In order
> To do that register write we have to again enable and prepare the clocks.
Please look the at suspend/resume code and count the
clock_enable/disable manually. After a suspend/resume cycle, you have
enabled the clock twice, but disabled it once.
I think you have to abstract the clock handling behind runtime PM. I
haven't done this myself yet, but the strong feeling that this is a
possible solution to your problem. These links might help:
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: OpenPGP digital signature
More information about the linux-arm-kernel