[PATCH v2 13/14] ARM: STi: DT: STiH410: Add usb2 picophy dt nodes

Arnd Bergmann arnd at arndb.de
Thu Nov 13 03:15:35 PST 2014

On Thursday 13 November 2014 11:00:16 Peter Griffin wrote:
> +       soc {
> +               usb2_picophy0: usbpicophy at 0 {
> +                       compatible = "st,stih407-usb2-phy";
> +                       reg = <0xf8 0x04>,      /* syscfg 5062 */
> +                             <0xf4 0x04>;      /* syscfg 5061 */

I think the node name for the phy should be "phy at f8" instead of usbpicophy at 0
by common convention. I notice that there are some existing instances of
this, you can probably change them as well. Linux doesn't normally care
about the node names.

It also seems that you have put the node in the wrong place, as the reg
property apparently refers to a different address space. Did you mean
to put this under the syscfg_core node?


More information about the linux-arm-kernel mailing list