[PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode
sakari.ailus at iki.fi
Wed Nov 5 07:22:52 PST 2014
On Wed, Nov 05, 2014 at 04:15:38PM +0100, Boris Brezillon wrote:
> On Wed, 5 Nov 2014 17:08:15 +0200
> Sakari Ailus <sakari.ailus at iki.fi> wrote:
> > I would keep the original file name, even if the compatibility definitions
> > are there. I don't see any harm in having them around as well.
> That's the part I was not sure about.
> The goal of this patch (and the following ones) is to deprecate
> v4l2_mbus_pixelcode enum and its values by adding a #warning when
> v4l2-mediabus.h file is included, thus encouraging people to use new
> Do you see another solution to generate such warnings at compilation
> time ?
Do you think we need a warning? In a general case we can't start renaming
interface headers once the preferred interface changes, albeit in this case
it would be a possibility.
The presence of the formats defined from now on only in the new definitions
should be good enough. There are many cases such as this in the V4L2 and
I wonder what others think.
e-mail: sakari.ailus at iki.fi XMPP: sailus at retiisi.org.uk
More information about the linux-arm-kernel