[PATCH v4 1/9] PM / Domains: Change prototype for the ->attach_dev() callback

Geert Uytterhoeven geert+renesas at glider.be
Mon Nov 3 07:34:48 PST 2014

From: Ulf Hansson <ulf.hansson at linaro.org>

Convert the prototype to return and int. This is just an initial step,
needed to support error handling.

Signed-off-by: Ulf Hansson <ulf.hansson at linaro.org>
Acked-by: Geert Uytterhoeven <geert+renesas at glider.be>
Acked-by: Pavel Machek <pavel at ucw.cz>
Acked-by: Kevin Hilman <khilman at linaro.org>
Signed-off-by: Geert Uytterhoeven <geert+renesas at glider.be>

Ulf wrote:

This patch is intended as fix for 3.18 rc[n]. Why?

There are other SOC specific patches around that adds genpd support and which
implements the ->attach_dev() callback. To prevent having an "atomic" patch
during the next release cycle, let's change the prototype now instead.

Further patches will add the actual error handling in genpd and these can then
be reviewed and tested thoroughly.
 include/linux/pm_domain.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
index 73e938b7e9374c68..d44f071988a861ff 100644
--- a/include/linux/pm_domain.h
+++ b/include/linux/pm_domain.h
@@ -72,7 +72,7 @@ struct generic_pm_domain {
 	bool max_off_time_changed;
 	bool cached_power_down_ok;
 	struct gpd_cpuidle_data *cpuidle_data;
-	void (*attach_dev)(struct device *dev);
+	int (*attach_dev)(struct device *dev);
 	void (*detach_dev)(struct device *dev);

More information about the linux-arm-kernel mailing list