[PATCH] ARM: imx: Explicitly select CONFIG_SPI

Fabio Estevam festevam at gmail.com
Mon Nov 3 04:45:20 PST 2014


Hi Shawn,

On Mon, Nov 3, 2014 at 4:26 AM, Shawn Guo <shawn.guo at linaro.org> wrote:
> On Wed, Oct 29, 2014 at 07:19:28PM -0200, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam at freescale.com>
>>
>> Since 3.18-rc1 CONFIG_SPI is no longer automatically selected for
>> imx_v4_v5_defconfig and imx_v6_v7_defconfig, so in order to keep the same
>> behaviour as previous kernel versions and avoid regressions, let's explicitly
>> select CONFIG_SPI.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
>> ---
>> Shawn,
>>
>> If possible, please apply this as a bug fix for 3.18.
>
> Can you please mention the commit that introduced the regression in the
> commit log?

The problem is that 'git bisect' did not produce a valid result for
me. It says that:

commit cf377ad7d42c566356d79049536d9cb37499cb77
Merge: 212fe84 d8f0faa
Author: Linus Torvalds <torvalds at linux-foundation.org>
Date:   Wed Oct 8 17:13:04 2014 -0400

    Merge tag 'soc-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc


, is the first bad commit, but this does not look correct, so I was
not able to really identify the commit that caused this regression.

Here is my procedure (starting at 3.18-rc1):

git bisect start
git bisect bad
git bisect good v3.17
make imx_v6_v7_defconfig
cat .config | grep CONFIG_SPI=y

Then I add "git bisect good or bad" depending on the output of the
'cat' command.

Any ideas?



More information about the linux-arm-kernel mailing list