[PATCH v3 1/4] ARM: Kirkwood: Add board file for netxbig LEDs

Andrew Lunn andrew at lunn.ch
Thu May 15 13:36:12 PDT 2014


On Thu, May 15, 2014 at 04:38:43PM +0200, Arnd Bergmann wrote:
> On Thursday 15 May 2014 16:23:42 Andrew Lunn wrote:
> > diff --git a/arch/arm/mach-mvebu/board-netxbig.c b/arch/arm/mach-mvebu/board-netxbig.c
> > new file mode 100644
> > index 000000000000..e6f2f547b1c7
> > --- /dev/null
> > +++ b/arch/arm/mach-mvebu/board-netxbig.c
> > 
> 
> I'd rather see these tables as part of the netxbig led driver in a
> separate file, but if we keep it here, can you rename the file to
> kirkwood-netxbig-led.c? We are not really doing board files any
> more, and this isn't one.

I will rename it. Simon has said he hopes to test on real hardware
soon, so once i have the results i will respin the patch set.

Adding a DT binding to the LED driver is probably a task for next
cycle.

	Andrew



More information about the linux-arm-kernel mailing list